fix(ui): restore tool selection feedback in onboarding and render selected tool names in review#1633
Open
whtssub wants to merge 3 commits intokagent-dev:mainfrom
Open
fix(ui): restore tool selection feedback in onboarding and render selected tool names in review#1633whtssub wants to merge 3 commits intokagent-dev:mainfrom
whtssub wants to merge 3 commits intokagent-dev:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a blocker bug where users cannot select tools in the UI quick agent builder wizard's tool selection step. The issue was caused by server name format mismatches during tool selection comparison. Additionally, the PR improves the tool feedback in the review step by displaying individual tool names instead of just server names, and fixes duplicate key warnings in the UI.
Changes:
- Normalize server-name matching in ToolSelectionStep to handle both "namespace/name" and plain name formats using a new
serverNamesMatchutility function - Improve ReviewStep rendering to display individual tool names per tool and generate unique keys per tool to eliminate React duplicate key warnings
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ui/src/components/onboarding/steps/ToolSelectionStep.tsx | Imports and uses serverNamesMatch function to properly match tools when server names may be in different formats (namespace/name vs plain name) |
| ui/src/components/onboarding/steps/ReviewStep.tsx | Refactors tool rendering to show individual tool names instead of just server names, uses flatMap for better data structure handling, and generates unique keys combining server name, tool name, and tool index to fix duplicate key issues |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ected tool names in review Signed-off-by: SubhasmitaSw <subhasmitaswain232@gmail.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalize server-name matching for Step 3 checkboxes and use unique per-tool keys in Step 4 to fix duplicate key issues.
refs #1614
I have rendered/tested the updated docker image locally and found consistent desired results. Refer the below images.